Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Upstream Testing #185

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Enable Upstream Testing #185

wants to merge 10 commits into from

Conversation

bryanculver
Copy link
Member

@bryanculver bryanculver commented Dec 6, 2022 •
edited
Loading

  • Updated Dockerfile to be compatible with upstream testing
  • Added workflow fragment to trigger testing

Should close:

Outstanding Items:

  • Pylint Failures
    • I think this should go in to unblock some of the dependency issues in Documentation Updates #184, even if we fix all of the linting we're going to be blocked by Dolt test failures (see below)
  • Unit Test Failtures

bryanculver
bryanculver commented Dec 6, 2022
View reviewed changes
.github/workflows/upstream_testing.yml
Comment on lines +7 to +8
push: # yamllint disable rule:empty-values
# TODO: REMOVE PUSH LINE ABOVE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
push: # yamllint disable rule:empty-values
# TODO: REMOVE PUSH LINE ABOVE

Remove before merging.

@bryanculver
Copy link
Member Author

next is expected to fail because it goes to a new major version of Nautobot so can be safely ignored for now.

bryanculver and others added 8 commits December 9, 2022 14:52
@bryanculver
Proto update, blocking migration
ecb3bf6
@PavelSafronov
Fix migrations issue with 'branch' column (#187)
281fd25 
* Fix migrations issue "blob/text column 'branch' used in key specification without a key length" by changing the 'branch' column from TextField to CharField.

* Fix formatting.
@bryanculver
Updates to baseline
7a93f8b
@bryanculver
Nudge some dependencies around
ce27367
@bryanculver
Move nosec bandit line
fa29c7d
@bryanculver
Merge remote-tracking branch 'origin/upgrade-to-nautobot-1.5' into bs…
980891e 
…c-2023-upstream-testing
@bryanculver
Newer Dolt
cb65528
@bryanculver
Black and flake8
322cb89
@bryanculver bryanculver requested a review from a team March 8, 2023 13:46
@bryanculver bryanculver marked this pull request as ready for review March 8, 2023 13:46
@bryanculver bryanculver mentioned this pull request Mar 8, 2023
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanculver @PavelSafronov